Fix RabbitMQ runtime credentials - #397
Conversation
624f516 to
bb4b735
Compare
MoralCode
left a comment
MoralCode
left a comment
There was a problem hiding this comment.
Thanks for taking on this issue! Unfortunately this is a little more complex than changing build args to environment cars because of this config file.
Happy to chat solutions if you get stuck!
| RUN exec python3 update_config.py | ||
| RUN chmod +x /collectoss-rabbitmq-entrypoint.sh |
There was a problem hiding this comment.
This won't work. This script runs at build time and is the same as the entry point script. Its going to bake a config file into the container containing a hash of the default password (because a different password isnt provided at build time)
There was a problem hiding this comment.
Can we Keep the runtime wrapper, but remove RUN chmod +x and invoke it with /bin/sh. This makes config generation visibly runtime-only and keeps the image portable.
There was a problem hiding this comment.
@MoralCode Can you please guide me what needs to be done further
fccef95 to
bc4ed97
Compare
Signed-off-by: Deepanshu Tiwari <tiwarideepanshu235@gmail.com>
Signed-off-by: Deepanshu Tiwari <tiwarideepanshu235@gmail.com>
bc4ed97 to
9aab022
Compare
|
I notice this change is made from a |
|
superseded by #437, which takes a different approach by relying on the upstream rabbitmq image |
* feat: detect AI disclosure in branch name Add a branchname detector that flags branches created by AI coding CLIs/agents using their conventional prefixes (codex/, claude/, cursor/, copilot/, devin/, cline/, aider/, gemini/), following the pattern noticed in chaoss/CollectOSS#397. The current branch is resolved once per scan via a new gitops.GetCurrentBranch and passed into detection.Input so all commits in the scan share it. Detached HEAD (common in CI checkouts) yields an empty branch name and no finding, rather than an error. Refs #50 Signed-off-by: Emirhankeles10 <muhanmet_emirhan10@hotmail.com> * docs: mention branchname detector in README Signed-off-by: Emirhankeles10 <muhanmet_emirhan10@hotmail.com> --------- Signed-off-by: Emirhankeles10 <muhanmet_emirhan10@hotmail.com> Co-authored-by: Emirhankeles10 <muhanmet_emirhan10@hotmail.com>
2 participants
Change rabbit mq variables from build time to runtime by changing it from args to environment variables
Fix issue #278